CAPI: Enable use of Legacy host when applicable. #1747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds DEBUG logging for the selection.
* Some `Optiona[str]` required. * Remove old pre-CAPIData comment about adding it
* Renames `plug.notify_newdata()` to the more precise `notify_capidata()`. * If CAPI data was from SERVER_LEGACY, then use plugin `cmdr_data_legacy()` instead of `cmdr_data()`.
`mypy EDMarketConnector.py` was throwing a warning:
By default the bodies of untyped functions are not checked, consider using --check-untyped-defs [annotation-unchecked]
for some things. Bizarrely including e.g.
play_bad: bool = False
It can be `tk.NORMAL` or `tk.DISABLED`. Why `True` was ever used I don't know, possibly relying on undefined behaviour. However, those 'types' end up as `Literal['normal']` and `Literal['disabled']` and the only way to declare a Union of those is to be explicit with the actual strings. tk.(NORMAL|DISABLED) are not a types.
Lost the `sys.platform == ` part of:
`sys.platform == 'darwin' and ...`
As we already took some care in the EDDN code we can just make `cmdr_data_legacy()` call through to `cmdr_data()`.
For now warn against trying to use extra CAPIData properties to determine the galaxy.
* Additional Allowed Imports `from companion ...`. * Plugin authors will still need to chain `cmdr_data_legacy()` to calling `cmdr_data()`, but with sanctioned access to `data.source_host` they can then determine the galaxy data source. * Re-worked the documentation for CAPI data a little to make all of this as clear as possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a separate CAPI host for Legacy data. Enable use of this.
Closes #1728