Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1654] Add Ship Jump Range and Cargo Capacity to Inara #2212

Merged

Conversation

Rixxan
Copy link
Contributor

@Rixxan Rixxan commented Apr 27, 2024

Description

As of mid-2022, Inara includes the ability to set the maximum ship jump range and cargo capacity of a given ship to the setCommanderShip event. This PR adds that data to the information we send to Inara, and increases the number of places where this data event is updated.

This is done by processing this data anytime a Loadout event is sent, including on session startup as all of the data needed can be found on startup events. Additionally, the update for setCommanderShip is moved out of shipswap events and into any time the Loadout event is recorded by the game.

Type of Change

  • Enhancement

How Has This Been Tested?

  • Tested with various setCommanderShip event triggers to determine where data is available
  • Ensured duplicate events are not sent to Inara where possible on Loadout events

Resolves #1654

@Rixxan Rixxan added enhancement Plugins Anything related to plugins python Pull requests that update Python code Inara Ready for Review PRs ready for review and merge labels Apr 27, 2024
@Rixxan Rixxan added this to the 5.11.0 milestone Apr 27, 2024
@Rixxan Rixxan self-assigned this Apr 27, 2024
@Rixxan Rixxan linked an issue Apr 27, 2024 that may be closed by this pull request
Copy link
Member

@C1701D C1701D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rixxan Rixxan merged commit 3e0d6e5 into EDCD:develop May 13, 2024
3 checks passed
@Rixxan Rixxan deleted the enhancement/1654/add-shiprange-and-cargocapacity branch May 13, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Inara Plugins Anything related to plugins python Pull requests that update Python code Ready for Review PRs ready for review and merge
Projects
None yet
2 participants