improved pattern null check #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified short circuit on 'pattern' parameter to use a truthy check rather than explicitly checking against undefined. This will stop the filter from processing when the pattern is null or empty in addition to undefined.
|
@michaelmalone Thank you for your contribution! Would you mind writing a test to cover this case as well? |
|
Sure, will add the test soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modified short circuit on 'pattern' parameter to use a truthy check
rather than explicitly checking against undefined. This will stop the
filter from processing when the pattern is null or empty in addition to
undefined.