Convert XLS files to XLSX to be compatible with xl2times #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willcattoneeca
approved these changes
Dec 19, 2024
willcattoneeca
approved these changes
Dec 19, 2024
|
Thanks Will. I can push the new raw tables file in a few minutes to make this pass CI. |
Ah, have already done this! |
searleluke
approved these changes
Dec 19, 2024
siddharth-krishna
added a commit
to etsap-TIMES/xl2times
that referenced
this pull request
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xl2timesdoes not support the old XLS file format, so this PR converts the 2 files in the old format to the newer XLSX format.I don't have Excel, so I did this using an online tool. Once #63 is merged in, we can use
raw_tables.txtto verify that the changes in this PR did not change the contents of the two files. EDIT: alas, we can't use it because the old XLS files were not included inraw_tables.txt(doh!). Is there some way to check that the new files are equivalent to the old ones?