-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Summarize what changed inbetween two runs #13
Conversation
This compares blocked and cookieblocked base domains. Blocking different subdomains of the same base domain is not reported.
09c685c
to
c5ef35a
Compare
Would be nice to get these emailed from scheduled runs eventually. |
@@ -1,2 +1,4 @@ | |||
colorama==0.3.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These requirements are installed inside the docker image, and validate.py
is run outside of it. We can either add a separate requirements file to install dependencies for the outer script, or we could run validate.py
inside Docker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any downsides to running it inside Docker? We'd still be able to run it by itself manually on arbitrary result files I presume.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inside Docker is fine, I think, though it will split some of the logic out of runscan.sh
. Update Dockerfile
to copy validate.py
and results.json
into the docker container, then have docker-entry.sh
call this script after it runs the crawler.
Run validate.py from docker-entry.sh. Update Dockerfile to copy validate.py and results.json into docker container.
This compares blocked and cookieblocked base domains. Blocking different subdomains of the same base domain is not reported.
Example output from a 500 site run comparing master and the
navigator.sendBeacon
branch:Closes EFForg/privacybadger#1019. We can open followup issues/PRs as needed.