Check domains with PyFunceble #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add script in audit.py that looks through historic results.json data and counts how many times badger-sett has learned to block each domain. Warning: this script messes with your file system! Don't use it if you have uncommitted changes.
Use the PyFunceble tool to check domains for validity before visiting them. Clear pyfunceble cache whenever we refresh the majestic list.
|
TODO: turn off PyFunceble's automatic "log sharing:" https://pyfunceble.readthedocs.io/en/latest/logs-sharing.html |
|
Using this for the top 2k sites, PyFunceble finds 88 of them (4%) anything other than "Active." There are still several sites that PF finds "Active" but that return DNS errors when we try to browse to them in the scanner. Looks like this will be a partial solution at best. |
Closed
funilrys
added a commit
to funilrys/badger-sett
that referenced
this pull request
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the PyFunceble tool to check domains for validity before visiting them.
Clear pyfunceble cache whenever we refresh the majestic list.
#21