Firefox Nightly's settings dark mode

[rugk]

Type: code issue

I've discovered a big CSS problem in my add-on and checked some other add-ons, to see you are also affected.

In Firefox 68 (Nightly), the system' dark mode is governed by prefers-color-scheme is also applied to about:addons.

That includes add-on options page (presumably only if they use browserStyle?).

This is how your add-on looks like then:

See rugk/offline-qr-code#190 for details.

---

So I've opened https://discourse.mozilla.org/t/firefox-68-nightly-added-dark-version-to-about-addons-breaking-many-add-ons/38716 for discussing this with Mozilla, as I currently have no idea what their plan in this direction is.

In any case, you likely will have to adjust your add-on.

[pipboy96]

Duplicate of #12484.

[pipboy96]

I will release a PR for this issue soon.

[rugk]

Okay, but remember this is currently only implemented in Nightly. So to not make it look awkward, you possibly also have to wait some time until that change hits Firefox Stable, before releasing it.
See https://bugzilla.mozilla.org/show_bug.cgi?id=1544212

[pipboy96]

@rugk It won't do anything unless dark mode is actually on.

[rugk]

It will. If you use prefers-color-scheme that is supported since Firefox 67, but the dark mode in about:addons is currently just in Nightly.

[pipboy96]

My current solution is to simply make a forced white bg on this page.

[rugk]

Well if you do that, then possibly you need to do nothing/adjust nothing, because maybe Firefox may do so anyway for all add-ons, see https://phabricator.services.mozilla.com/D28369.

Again: We speak about Nightly. Everything may still change.

[pipboy96]

@rugk That's not really "handling" dark mode, more like a stopgap. I guess Nightly users should expect possible breakage, so fixing on our side immediately is not a priority, even though it's not very difficult.

[rugk]

That's what I've said… 😊

[pipboy96]

@rugk Is it fine for us to not make any fixes until FF fixes that upstream?

[rugk]

To my judgement (I am nobody official here.) yes. When it is in beta, you should possibly have a look and tweak it, so it looks nice.