Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add-on options page should support dark mode #190

Closed
rugk opened this issue Apr 27, 2019 · 1 comment
Closed

Add-on options page should support dark mode #190

rugk opened this issue Apr 27, 2019 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@rugk
Copy link
Owner

rugk commented Apr 27, 2019

In Firefox 68 (Nightly), the system' dark mode is governed by prefers-color-scheme (see also #186 (comment)) is also applied to about:addons.

Due to browserStyle (I guess), we inherit that, and as we did not expect that, the whole options page then looks like that:
image

STR

Just set your system to dark mode. (depends on your system)

Fix

Likely we need custom styles for prefers-color-scheme, but that could be hard, especially for the input elements, which we – so far – did not even re-style.

Also it would be good to find the exact version of Firefox, where the add-on page has implemented a dark mode… 🙄

Reproduce

Could not reproduce in:

  • Firefox 67.0b15
  • Firefox 66
@rugk rugk added the bug Something isn't working label Apr 27, 2019
@rugk rugk changed the title Add-on page should support dark mode Add-on options page should support dark mode Apr 27, 2019
@rugk
Copy link
Owner Author

rugk commented Apr 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant