-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add-on options page should support dark mode #190
Comments
rugk
changed the title
Add-on page should support dark mode
Add-on options page should support dark mode
Apr 27, 2019
This was referenced Apr 27, 2019
BTW, asked some questions about that change: https://discourse.mozilla.org/t/firefox-68-added-dark-version-to-about-addons-breaking-many-add-ons/38716?u=rugkx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In Firefox 68 (Nightly), the system' dark mode is governed by
prefers-color-scheme
(see also #186 (comment)) is also applied toabout:addons
.Due to
browserStyle
(I guess), we inherit that, and as we did not expect that, the whole options page then looks like that:STR
Just set your system to dark mode. (depends on your system)
Fix
Likely we need custom styles for
prefers-color-scheme
, but that could be hard, especially for the input elements, which we – so far – did not even re-style.Also it would be good to find the exact version of Firefox, where the add-on page has implemented a dark mode… 🙄
Reproduce
Could not reproduce in:
The text was updated successfully, but these errors were encountered: