Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google currency charts currently blocked #864

Closed
episanty opened this issue Jun 10, 2016 · 4 comments
Closed

Google currency charts currently blocked #864

episanty opened this issue Jun 10, 2016 · 4 comments
Labels
broken site help wanted heuristic Badger's core learning-what-to-block functionality

Comments

@episanty
Copy link

Looking for currency conversions on Google, such as e.g. https://www.google.co.uk/search?q=1usd+to+gbp, in general produces a widget with a currency conversion tool and a chart of the recent history of the exchange rate. Since recently, however, Privacy Badger blocks this chart:

selection_034

This impairs the usability of a site that the user is explicitly asking for, and it does not expose the user to additional external tracking - the user is already visiting Google under their T&Cs, and the chart is provided by Google. Thus Privacy Badger should allow the chart through. (Whether this can be done without creating an ugly exception, of course, is another matter.)

@alexristich
Copy link
Contributor

I started looking into this issue, and it seems there is a higher level problem. The resource that is being blocked comes from encrypted.google.com, which is not on the same FQDN as the page you're visiting (i.e. google.com vs. google.co.uk).

I'm working on a tweak right now that will override any heuristic action for subdomains of a page that a user is visiting, but this does not include a solution for sites such as Google that host services across multiple top level domains. Immediately, no good generic solution comes to mind for this problem, but having it work across properties on the same TLD should be an improvement nonetheless.

I'm thinking that perhaps in the case of popular services like Google, it can just be manually configured (such as having a reference table), as this would cover most cross-TLD services.

@alexristich
Copy link
Contributor

Ah, just realized that the extension already gracefully handles blocked resources from the same base domain :)

So, the issue is just with sites like Google that have regional TLDs but call resources from properties with other TLDs. Continuing to poke around the code and see how everything is arranged. I've got a couple ideas on how to handle this neatly; will see if I can get something put together this weekend.

@ghostwords
Copy link
Member

Same as #1253?

@ghostwords ghostwords added the heuristic Badger's core learning-what-to-block functionality label May 4, 2017
@ghostwords
Copy link
Member

Should be fixed by #910.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
broken site help wanted heuristic Badger's core learning-what-to-block functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants