Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adjusting the heuristic for sites that exist across many ccTLDs #1253

Closed
pde opened this issue Mar 18, 2017 · 6 comments
Closed

Consider adjusting the heuristic for sites that exist across many ccTLDs #1253

pde opened this issue Mar 18, 2017 · 6 comments
Labels
enhancement heuristic Badger's core learning-what-to-block functionality MDFP Multi-domain first parties: lists of domains that should be treated as related to each other wontfix

Comments

@pde
Copy link
Contributor

pde commented Mar 18, 2017

Looking at #1251, and the entries for Yahoo, Google, and Amazon in src/multiDomainFirstParties.js, it seems that an issue we can expect to see over and over again is a company's CDN domain being blocked because they have company.com, company.co.uk, company.jp, company.fr, etc.

We could probably just adjust the counting measure for our heuristics to only count company once, and that would prevent this from recurring. We could wildcard this across all public suffixes, or just ccTLDs.

It shouldn't prevent us from catching any real trackers.

@ghostwords ghostwords added the heuristic Badger's core learning-what-to-block functionality label Mar 18, 2017
@jawz101
Copy link
Contributor

jawz101 commented Mar 29, 2017

My gut reaction is I'm hesitant to the implications.

@ghostwords
Copy link
Member

I like it, and I think this is the proper fix for #1251, given the snitch map:

badger.storage.snitch_map.getItem("r9cdn.net")
["kayak.com", "kayak.com.au", "kayak.co.uk"]

@jawz101
Copy link
Contributor

jawz101 commented Mar 31, 2017

Is it possible to confirm matching SSL certs or owner info something? Call me ignorant but this makes me think of cybersquatting. Are there security implications by assuming hello.us is the same as hello.uk, hello.mx, etc.?

@jawz101
Copy link
Contributor

jawz101 commented Mar 31, 2017

While the list is ugly, there are relatively few companies which own a bunch of country domains. Most own different secondary domains if anything. I'm trying to wrap my head around if this would assume something not secure.

@ghostwords
Copy link
Member

ghostwords commented Apr 3, 2017

The security implication is that Badger may incorrectly consider example.com and example.net to belong to the same party (it's not guaranteed, just reasonably likely), and so may undercount a third-party domain it saw perform tracking on both example.com and example.net by one (it will take one extra sighting to start blocking this third-party).

@ghostwords
Copy link
Member

This doesn't seem worth doing at this point. MDFP entries are typically a mix of country code domains, and domains that are not obviously associated with each other; it's rarely country codes alone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement heuristic Badger's core learning-what-to-block functionality MDFP Multi-domain first parties: lists of domains that should be treated as related to each other wontfix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants