-
-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider adjusting the heuristic for sites that exist across many ccTLDs #1253
Comments
My gut reaction is I'm hesitant to the implications. |
I like it, and I think this is the proper fix for #1251, given the snitch map:
|
Is it possible to confirm matching SSL certs or owner info something? Call me ignorant but this makes me think of cybersquatting. Are there security implications by assuming hello.us is the same as hello.uk, hello.mx, etc.? |
While the list is ugly, there are relatively few companies which own a bunch of country domains. Most own different secondary domains if anything. I'm trying to wrap my head around if this would assume something not secure. |
The security implication is that Badger may incorrectly consider |
This doesn't seem worth doing at this point. MDFP entries are typically a mix of country code domains, and domains that are not obviously associated with each other; it's rarely country codes alone. |
Looking at #1251, and the entries for Yahoo, Google, and Amazon in
src/multiDomainFirstParties.js
, it seems that an issue we can expect to see over and over again is a company's CDN domain being blocked because they havecompany.com
,company.co.uk
,company.jp
,company.fr
, etc.We could probably just adjust the counting measure for our heuristics to only count
company
once, and that would prevent this from recurring. We could wildcard this across all public suffixes, or just ccTLDs.It shouldn't prevent us from catching any real trackers.
The text was updated successfully, but these errors were encountered: