Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Nvidia domains to MDFP list #2050

Merged
merged 1 commit into from
Jun 26, 2018
Merged

Add Nvidia domains to MDFP list #2050

merged 1 commit into from
Jun 26, 2018

Conversation

ghostwords
Copy link
Member

Fixes #2048.

Related to #1253.

@ghostwords ghostwords added the MDFP Multi-domain first parties: lists of domains that should be treated as related to each other label Jun 3, 2018
@ghostwords ghostwords requested a review from bcyphers June 3, 2018 17:11
@ghostwords
Copy link
Member Author

DNT header test fixed in #2047.

@ghostwords
Copy link
Member Author

ghostwords commented Jun 3, 2018 •
edited
Loading

Error report counts by date, site domain and exact blocked nvidia subdomain:

+---------+-----------------------------------+---------------------+-------+
| ym      | blocked_fqdn                      | fqdn                | count |
+---------+-----------------------------------+---------------------+-------+
| 2018-06 | assets.nvidia.com                 | www.nvidia.fi       |     1 |
| 2018-05 | images.nvidia.com                 | www.nvidia.it       |     1 |
| 2018-05 | metrics.nvidia.com                | www.nvidia.it       |     1 |
| 2018-05 | www.nvidia.com                    | www.nvidia.co.uk    |     1 |
| 2018-04 | images.nvidia.com                 | www.nvidia.co.uk    |     2 |
| 2018-04 | www.nvidia.com                    | www.nvidia.co.uk    |     2 |
| 2018-04 | images.nvidia.com                 | www.nvidia.de       |     1 |
| 2018-04 | www.nvidia.com                    | www.nvidia.de       |     1 |
| 2018-03 | assets.nvidia.com                 | www.nvidia.co.kr    |     1 |
| 2018-03 | assets.nvidia.com                 | www.nvidia.cz       |     1 |
| 2018-03 | assets.nvidia.com                 | www.nvidia.pl       |     1 |
| 2018-03 | images.nvidia.com                 | www.nvidia.co.kr    |     1 |
| 2018-03 | images.nvidia.com                 | www.nvidia.co.uk    |     1 |
| 2018-03 | images.nvidia.com                 | www.nvidia.cz       |     1 |
| 2018-03 | images.nvidia.com                 | www.nvidia.de       |     1 |
| 2018-03 | metrics.nvidia.com                | www.nvidia.co.uk    |     1 |
| 2018-03 | metrics.nvidia.com                | www.nvidia.pl       |     1 |
| 2018-03 | nvidia.demdex.net                 | www.nvidia.co.uk    |     1 |
| 2018-03 | nvidia.demdex.net                 | www.nvidia.com      |     1 |
| 2018-03 | nvidia.demdex.net                 | www.nvidia.pl       |     1 |
| 2018-03 | smetrics.nvidia.com               | www.geforce.com     |     1 |
| 2018-03 | www.nvidia.com                    | www.nvidia.co.kr    |     1 |
| 2018-03 | www.nvidia.com                    | www.nvidia.co.uk    |     1 |
| 2018-03 | www.nvidia.com                    | www.nvidia.cz       |     1 |
| 2018-03 | www.nvidia.com                    | www.nvidia.de       |     1 |
...

bcyphers
bcyphers approved these changes Jun 20, 2018
View reviewed changes
Copy link
Contributor

@bcyphers bcyphers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ghostwords ghostwords merged commit c1d974b into master Jun 26, 2018
ghostwords added a commit that referenced this pull request Jun 26, 2018
@ghostwords
Merge pull request #2050.
af2dda9 
Add Nvidia domains to MDFP list.
@ghostwords ghostwords deleted the add-nvidia-to-mdfp branch June 26, 2018 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcyphers bcyphers bcyphers approved these changes

Assignees
No one assigned
Labels
MDFP Multi-domain first parties: lists of domains that should be treated as related to each other
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghostwords @bcyphers