Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Privacy Badger Breaks tripadvisor.co.uk #1560

Closed
shadyeglenn opened this issue Aug 4, 2017 · 5 comments
Closed

Privacy Badger Breaks tripadvisor.co.uk #1560

shadyeglenn opened this issue Aug 4, 2017 · 5 comments
Labels
broken site heuristic Badger's core learning-what-to-block functionality MDFP Multi-domain first parties: lists of domains that should be treated as related to each other

Comments

@shadyeglenn
Copy link

shadyeglenn commented Aug 4, 2017 •
edited
Loading

When Privacy Badger is enabled, all Trip Advisor pages show up as left justified text with broken image links. If I disable Privacy Badger in Chrome, Trip Advisor loads fine (testing primarily on tripadvisor.co.uk). I tried whitelisting Trip Advisor and sliding all of the domains to the green section to allow all Trip Advisor sites, but the issue still shows up.
@ghostwords
Copy link
Member

Do you have any other privacy/ad blocking extensions, or does this happen exclusively with Privacy Badger?

@ghostwords
Copy link
Member

Does Privacy Badger report static.tacdn.com as blocked on TripAdvisor pages, by any chance?

@ghostwords
Copy link
Member

Looks like tripadvisor.com and tacdn.com are already associated together by Privacy Badger. The problem is that none of the regional TripAdvisor domains are there. Here are three example pages that make Privacy Badger start blocking TripAdvisor resources:

The quick fix would be to add all their regional URLs to their MDFP entry. We get lots of error reports for TripAdvisor. The proper fix might be to implement #1253.

@ghostwords ghostwords added heuristic Badger's core learning-what-to-block functionality important labels Aug 5, 2017
@shadyeglenn
Copy link
Author

Yep, Privacy Badger reports static.tacdn.com as blocked on TripAdvisor pages. I can workaround the issue by switching static.tacdn.com from block domain to block cookies, and after doing so TripAdvisor loads fine. Thanks!

@cowlicks
Copy link
Contributor

cowlicks commented Aug 9, 2017

I'm working on this, it should close #1253 as well

cowlicks added a commit to cowlicks/privacybadgerchrome that referenced this issue Aug 10, 2017
@cowlicks
use dyn tld node for tripadvisor & test
c150fca 
closes EFForg#1560
@cowlicks cowlicks mentioned this issue Aug 10, 2017
Closed
3 tasks
@ghostwords ghostwords added the MDFP Multi-domain first parties: lists of domains that should be treated as related to each other label Feb 23, 2018
@ghostwords ghostwords mentioned this issue Apr 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
broken site heuristic Badger's core learning-what-to-block functionality MDFP Multi-domain first parties: lists of domains that should be treated as related to each other
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add dynamic TLD's to the MDFP list cowlicks/privacybadgerchrome
3 participants
@shadyeglenn @cowlicks @ghostwords