-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support navigator.doNotTrack #1861
Conversation
c833a7f
to
b93953f
Compare
Using the "spam frames with messages every ten milliseconds until the frame responds or message limit is hit from Using our current "content script messages background page and acts upon response" approach, I see timings that are about twice as slow (8 ms vs. 16 ms in Firefox, for example). Since both approaches are relatively fast while neither succeeds at intercepting the inline script (at "0 ms"), I see no reason to switch to the |
Using |
We could otherwise end up performing assertions before the body finished being populated (such as by an inline script).
Conflicts: tests/selenium/pbtest.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I haven't been able to find any bugs. The test script gist does sometimes display 'unset (navigator.doNotTrack="unspecified")' when I open it in firefox with privacy badger enabled, but this has not caused the tests to fail for me. Maybe we should change the test page's timeout from 50 to 100 ms, just to be safe?
Support navigator.doNotTrack
Fixes #1835, fixes #1260.
For example, see this Medium blog page with a bunch of JavaScript DNT checks.