Improve Facebook link unwrapping #2033
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has some conflicts with #2016 -- @ghostwords should I just merge these changes into that PR? |
|
Yeah, if that makes things easier. By the way, suggest making several small(er) commits instead of monolithic "bug fixes" commits. I mean it's a balance, but it makes sense if it makes things clearer (can review one change at a time in isolation) and adds flexibility (can back out individual pieces without needing to rewrite the whole). Always easier to squash unnecessarily-detailed commits than to break up a confusing commit. |
|
I incorporated the changes here into #2016, so this branch is closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a few issues that have come up since we merged the feature. Some of the issues are pulled from https://github.com/mgziminsky/FacebookTrackingRemoval.
Closes #2012, closes #2014, closes #2018.