Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore session cookies #2420

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Ignore session cookies #2420

wants to merge 1 commit into from

Conversation

ghostwords
Copy link
Member

@ghostwords ghostwords commented Jul 11, 2019

Fixes #1545.

  • Does checking expiration only make sense in onResponseStarted (not onBeforeSendHeaders)? Do we currently ignore some incoming cookies but then record the very same cookies on the way out?
  • Also ignore short-lived cookies? Ignore only short-lived cookies? Session cookies seem to be much more persistent in practice.
  • Evaluate impact using badger-sett.
  • Fix/add new tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include cookie duration in tracking heuristic
1 participant