Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration to forget __cfduid-linked domains #2536

Merged
merged 2 commits into from
Jan 7, 2020
Merged

Conversation

ghostwords
Copy link
Member

@ghostwords ghostwords commented Jan 7, 2020

Fixes #1538, fixes #2530.

Follows up on 775ff3e.

This migration gets all "__cfduid" cookies and collects their site (first-party) domains. It then goes through each tracking domain in snitch_map and throws away any site domain entries that are found in the "__cfduid" site domains list. It then rebuilds action and snitch maps.

Since we only seem to have site domains for the "__cfduid" cookies, we can't differentiate between Cloudflare and non-Cloudflare tracking domains, so this may end up removing non-Cloudflare tracking domains (that were seen on the same site domains as Cloudflare tracking domains). This should be OK as there shouldn't be too many, and Privacy Badgers will automatically relearn to block them.

@ghostwords ghostwords added the migrations Badger user data modifications label Jan 7, 2020
@ghostwords
Copy link
Member Author

ghostwords commented Jan 7, 2020

Note that any Badger builds that include 775ff3e (master only, not yet released) will properly ignore "__cfduid" cookies. So for testing purposes you might want to back out the SameSite fix locally, or merge this branch onto the most recent release tag, or something like that.

Copy link
Contributor

@ablanathtanalba ablanathtanalba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all LGTM -- I tested by manually plucking out the SameSite fix code and going from there. Nice work

As snitch map contains only base domains.
ghostwords added a commit that referenced this pull request Jan 7, 2020
Add migration to forget __cfduid-linked domains.
@ghostwords ghostwords merged commit 0f7bbec into master Jan 7, 2020
@ghostwords ghostwords deleted the forget-cloudflare branch January 7, 2020 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migrations Badger user data modifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

snapfish family of sites broken Migrate domains blocked by __cfduid cookies.
2 participants