Add Amazon Publisher Services Tag surrogate; switch to extension URL-based surrogates #2801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghostwords
added
the
surrogates
As a web accessible resource URL, not a data URI string, to work around data URIs getting blocked by website CSPs.
ghostwords
force-pushed
the
add-amazon-apstag-surrogate
branch
2 times, most recently
from
6770b50
to
a1cd26e
Compare
ghostwords
force-pushed
the
add-amazon-apstag-surrogate
branch
from
a1cd26e
to
924f859
Compare
ghostwords
force-pushed
the
add-amazon-apstag-surrogate
branch
from
72747ba
to
6a2b81c
Compare
ghostwords
changed the title
ghostwords
changed the title
Broken by the update to manifest.json in 924f859
ghostwords
added a commit
that referenced
this pull request
Sep 23, 2021
Switch to extension URL-based surrogates to work around data URIs getting blocked by website CSPs. Add surrogate for Amazon Publisher Services Tag (to fix videos on CNN, probably elsewhere). To be followed by undoing 9869b70
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be followed up by undoing 9869b70 once the update containing this PR gets widely distributed.
To test:
c.amazon-adsystem.comc.amazon-adsystem.cominhostnamesto remove the redirect to our surrogate and make Privacy Badger simply block the domainPreviously: #1411 (comment), #1793 (comment), #1858