Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SentenceTransformer to NLQ #26

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add SentenceTransformer to NLQ #26

wants to merge 1 commit into from

Conversation

miguelmartin75
Copy link
Collaborator

Caveat: since SentenceTransformer reduces the input features from [B, T] -> [B, 768], I don't pass the token embeddings to the shared feature_encoder

@satwikkottur
Copy link
Collaborator

satwikkottur commented Sep 16, 2022 •
edited
Loading

Thanks @miguelmartin75 for this PR.

Two comments:

  1. Can we have choices for --predictor flag in options.py? Since we're adding addition predictors, would be nice to restrict that set.
  2. Between st and sentence_transformer (or even sent_transformer), I prefer the latter for readability. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miguelmartin75 @satwikkottur