profile display labels issue and carousel issue dots activate on scroll fixed #277
Conversation
src/assets/i18n/en.json
Outdated
| "VOICE_SEARCH_FAILED":"Voice search failed, please try again" | ||
| "VOICE_SEARCH_FAILED":"Voice search failed, please try again", | ||
| "ADD_PHOTO":"ADD PHOTO", | ||
| "REMOVE_PHOTO":"REMOVE PHOTO" |
There was a problem hiding this comment.
is it Remove photo or Remove Current Photo?
There was a problem hiding this comment.
it should be like remove photo and if we keep as remove current photo the hindi language is not meaningful for that
There was a problem hiding this comment.
Keep the same as previous one, else this might come up as an issue and we need products confirmation too
| @@ -1,6 +1,5 @@ | |||
| <div class="side-navigation"> | |||
| <div class="side-nav-header"> | |||
There was a problem hiding this comment.
removed the block as add the style instead of keeping listing from the top
| @@ -61,6 +61,7 @@ export class ProfilePage { | |||
| "preferred_language":this.selectedLanguage | |||
| }).subscribe((res:any)=>{ | |||
| this.setLanguage(res.result.preferred_language); | |||
| this.loadFormAndData(); | |||
There was a problem hiding this comment.
why is this added here?
Any reason?
There was a problem hiding this comment.
when we are changing the language in that page after changing we need to load the form again with translated stuff
There was a problem hiding this comment.
these changes are for the carousal dots active UI which was dicussed morning?
No description provided.