forked from rescript-lang/rescript
    
        
        - 
                Notifications
    You must be signed in to change notification settings 
- Fork 0
Support .mjs and .bs.mjs for Node.js ES-module-support, and lower "suffix" option into "package-specs" #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Draft
      
      
            ELLIOTTCABLE
  wants to merge
  25
  commits into
  prep/per-package-spec-suffix
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
per-package-spec-suffix
  
      
      
   
  
    
  
  
  
 
  
      
    base: prep/per-package-spec-suffix
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Draft
            
            Support .mjs and .bs.mjs for Node.js ES-module-support, and lower "suffix" option into "package-specs" #1
                    ELLIOTTCABLE
  wants to merge
  25
  commits into
  prep/per-package-spec-suffix
from
per-package-spec-suffix
  
      
      
   
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    9909eaa    to
    203dd42      
    Compare
  
    c07dcf0    to
    e3d6174      
    Compare
  
    203dd42    to
    84793c5      
    Compare
  
    e3d6174    to
    6653a23      
    Compare
  
    84793c5    to
    a4e5f50      
    Compare
  
    6653a23    to
    1077cd2      
    Compare
  
    a4e5f50    to
    cf4570a      
    Compare
  
    1077cd2    to
    177dc12      
    Compare
  
    cf4570a    to
    14a0dc2      
    Compare
  
    177dc12    to
    5162733      
    Compare
  
    14a0dc2    to
    a07018d      
    Compare
  
    b4fd150    to
    9f9353f      
    Compare
  
    This gets everything compiling again, but we're far from done! 😫
Additionally involed: - Split `cmj_case` type into new, simplified `leading_case` type and aformentioned `package_info` changes - Store file-extension(s) in `.cmj` files - Bump `cmj_magic_number`, as it now contains new information Backwards-compatibility is maintained.
In addition, add `.bs.cjs` alongside `.bs.mjs` as a cleaning-supported file-extension.
2266056    to
    e95b0e3      
    Compare
  
    3de2fb8    to
    ce8e5c9      
    Compare
  
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
See: rescript-lang#4116.
This is a version of the pull-request rebased to omit whitespace and ocamlformat reformattings, to demonstrate actual, algorithmic changes.