Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setup.cfg #31

Merged
merged 7 commits into from
Mar 16, 2022
Merged

Fix setup.cfg #31

merged 7 commits into from
Mar 16, 2022

Conversation

jesper-friis
Copy link
Contributor

No description provided.

CasperWA
CasperWA reviewed Mar 16, 2022
View reviewed changes
setup.cfg Outdated Show resolved Hide resolved
oteapi_dlite/strategies/filter.py Outdated Show resolved Hide resolved
oteapi_dlite/strategies/parse_image.py Outdated Show resolved Hide resolved
CasperWA
CasperWA requested changes Mar 16, 2022
View reviewed changes
oteapi_dlite/strategies/parse_image.py Outdated Show resolved Hide resolved
CasperWA and others added 3 commits March 16, 2022 09:22
@CasperWA
Update oteapi_dlite/strategies/parse_image.py
68bd354
@CasperWA
Update create-collection filter strategy value
baf9d5b
@CasperWA
Update tests with new strategy value
3d0e73f 
Use pydantic dataclasses instead of the built-in dataclasses.
Use `Any` instead of `dlite.Collection` for the type for stored DLite
Collections. This is due to pydantic not being able to validate
arbitrary types - and there is no way to allow this for a pydantic
dataclass. Then it needs to be converted to a pydantic BaseModel, but we
cannot do this.
@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2022 •
edited
Loading

Codecov Report

Merging #31 (3d0e73f) into master (e833675) will increase coverage by 0.80%.
The diff coverage is 94.11%.

❗ Current head 3d0e73f differs from pull request most recent head 38968b5. Consider uploading reports for the commit 38968b5 to get more accurate results

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   88.14%   88.94%   +0.80%     
==========================================
  Files          10       10              
  Lines         194      199       +5     
==========================================
+ Hits          171      177       +6     
+ Misses         23       22       -1
Flag Coverage Δ
linux 88.94% <94.11%> (+0.80%) ⬆️
windows 88.77% <94.11%> (+0.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
oteapi_dlite/strategies/filter.py 83.33% <87.50%> (+6.06%) ⬆️
oteapi_dlite/strategies/parse_excel.py 91.17% <100.00%> (ø)
oteapi_dlite/strategies/parse_image.py 90.00% <100.00%> (+0.81%) ⬆️
oteapi_dlite/strategies/serialise.py 84.84% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e833675...38968b5. Read the comment docs.

@CasperWA CasperWA enabled auto-merge (squash) March 16, 2022 08:57
@CasperWA CasperWA merged commit bcf4964 into master Mar 16, 2022
@CasperWA CasperWA deleted the fix-setup.cfg branch March 16, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CasperWA CasperWA CasperWA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jesper-friis @codecov-commenter @CasperWA