Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One letter words where not allowed in mappings, now they are #117

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

francescalb
Copy link
Contributor

@francescalb francescalb commented Jun 23, 2023

Description:

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist for the reviewer:

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

@francescalb francescalb requested a review from jesper-friis June 23, 2023 20:36
@francescalb francescalb enabled auto-merge June 23, 2023 20:36
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (70b80d9) 74.78% compared to head (053f200) 74.78%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #117   +/-   ##
=======================================
  Coverage   74.78%   74.78%           
=======================================
  Files          15       15           
  Lines        1285     1285           
=======================================
  Hits          961      961           
  Misses        324      324           
Impacted Files Coverage Δ
tripper/triplestore.py 81.90% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@francescalb francescalb merged commit 463489e into master Jun 23, 2023
@francescalb francescalb deleted the flb/allow_oneletter_words branch June 23, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants