Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearified that tripper does not depend on DLite and Pydantic #136

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

jesper-friis
Copy link
Contributor

Description:

Removed hard requirement on DLite in tests to clarify that tripper does not depend on DLite and Pydantic.

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.
  • Testing.

Checklist for the reviewer:

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

Removed hard requirement on DLite in tests.
@jesper-friis jesper-friis requested a review from sygout September 29, 2023 18:07
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (dba3971) 75.67% compared to head (4d29686) 75.60%.
Report is 8 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
- Coverage   75.67%   75.60%   -0.08%     
==========================================
  Files          17       17              
  Lines        1402     1402              
==========================================
- Hits         1061     1060       -1     
- Misses        341      342       +1     
Files Coverage Δ
tripper/mappings/__init__.py 100.00% <100.00%> (ø)
tripper/utils.py 86.88% <ø> (ø)
tripper/mappings/mappings.py 67.12% <50.00%> (-0.28%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@francescalb
Copy link
Contributor

Since we now do not depend on DLite, we should remove Dlite-Python from dependencies. However, as we have a test that checks for something that is included oly when we have Dlite installed I guess we can include DLite-Python in the dev requirements. Furthermore, we should then run the tests both with and without the dev_requirements installed and check that we get the correct output in both cases.

@francescalb
Copy link
Contributor

francescalb commented Oct 17, 2023

Since we now do not depend on DLite, we should remove Dlite-Python from dependencies. However, as we have a test that checks for something that is included oly when we have Dlite installed I guess we can include DLite-Python in the dev requirements. Furthermore, we should then run the tests both with and without the dev_requirements installed and check that we get the correct output in both cases.

I need to correct myself: DLite-Python is only in the docs and testing dependencies. I think this is fine then.
However, there are still some issues with missing dependencies during testing.

@francescalb francescalb merged commit 4d29686 into master Oct 19, 2023
@francescalb francescalb deleted the clarifying-dependencies branch October 19, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants