Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In tripper.convert, commented out recognised keys for oteapi strategies #212

Merged
merged 1 commit into from
May 15, 2024

Conversation

jesper-friis
Copy link
Contributor

Description

For some reason uncommenting these recognised keys makes load_container() returning a string with the IRI for the blank node representing the configuration of a strategy, instead of a Python dict with the configuration.

Needs more debugging, or preferable, an improved way for OTEAPI to serialise strategy configurations to RDF.

Type of change

  • Bug fix and code cleanup
  • New feature
  • Documentation update
  • Testing

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?
  • Is the code properly tested?

For some reason uncommenting these recognised keys makes
load_container() returning a string with the IRI for the blank node
representing the configuration of a strategy, instead of a Python dict
with the configuration.

Needs more debugging, or preferable, an improved way for OTEAPI to
serialise strategy configurations to RDF.
@jesper-friis jesper-friis requested a review from francescalb May 15, 2024 14:15
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.42%. Comparing base (69b877f) to head (7f5adeb).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #212   +/-   ##
=======================================
  Coverage   78.42%   78.42%           
=======================================
  Files          18       18           
  Lines        1650     1650           
=======================================
  Hits         1294     1294           
  Misses        356      356           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jesper-friis jesper-friis merged commit 41894c2 into master May 15, 2024
17 checks passed
@jesper-friis jesper-friis deleted the revert-recognised-keys-for-strategies branch May 15, 2024 19:09
@jesper-friis jesper-friis restored the revert-recognised-keys-for-strategies branch May 15, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants