-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added an additional test for convert #223
Conversation
For more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #223 +/- ##
==========================================
+ Coverage 78.43% 78.46% +0.03%
==========================================
Files 18 18
Lines 1665 1672 +7
==========================================
+ Hits 1306 1312 +6
- Misses 359 360 +1 ☔ View full report in Codecov by Sentry. |
For more information, see https://pre-commit.ci
This is not only adding a test. Can you provide a better description of the changes you have made? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov fails now.
More importantly, I think we should have better documentation on how to use these functionalities. Since we cannot do everything in one go, I suggest adding exmamples for how to use (and how it is usful to use it) in load_container. If we make an effort to update documentation every time we make an upgrade and fix we can reach our goal of good documentation.
Also, please descrive what this PR is about. This might be useful in the documentation update.
Correct. It also includes a fix. The description is updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this works nicely.
Description
Added a test to try to catch the issue seen in SS3_wrappers
Update
This PR now also fixes an issue in convert. Before
convert.load_container()
returned a ref. to a blank node if the value of a recognised key was a dict or list. Now it correctly returns the list or dict.A test was also added for this feature.
This PR only fixes a bug and adds more tests. No new functionality is added.
Type of change
Checklist for the reviewer
This checklist should be used as a help for the reviewer.