Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an additional test for convert #223

Merged
merged 13 commits into from
Jun 20, 2024
Merged

Added an additional test for convert #223

merged 13 commits into from
Jun 20, 2024

Conversation

jesper-friis
Copy link
Contributor

@jesper-friis jesper-friis commented Jun 17, 2024

Description

Added a test to try to catch the issue seen in SS3_wrappers

Update

This PR now also fixes an issue in convert. Before convert.load_container() returned a ref. to a blank node if the value of a recognised key was a dict or list. Now it correctly returns the list or dict.

A test was also added for this feature.

This PR only fixes a bug and adds more tests. No new functionality is added.

Type of change

  • Bug fix and code cleanup
  • New feature
  • Documentation update
  • Testing

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?
  • Is the code properly tested?

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.46%. Comparing base (8919a74) to head (fb2df62).

Files Patch % Lines
tripper/utils.py 0.00% 3 Missing ⚠️
tripper/convert/convert.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
+ Coverage   78.43%   78.46%   +0.03%     
==========================================
  Files          18       18              
  Lines        1665     1672       +7     
==========================================
+ Hits         1306     1312       +6     
- Misses        359      360       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@francescalb
Copy link
Contributor

francescalb commented Jun 18, 2024

This is not only adding a test. Can you provide a better description of the changes you have made?

Copy link
Contributor

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codecov fails now.

More importantly, I think we should have better documentation on how to use these functionalities. Since we cannot do everything in one go, I suggest adding exmamples for how to use (and how it is usful to use it) in load_container. If we make an effort to update documentation every time we make an upgrade and fix we can reach our goal of good documentation.

Also, please descrive what this PR is about. This might be useful in the documentation update.

@jesper-friis
Copy link
Contributor Author

This is not only adding a test. Can you provide a better description of the changes you have made?

Correct. It also includes a fix. The description is updated

@francescalb francescalb self-requested a review June 20, 2024 07:33
Copy link
Contributor

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this works nicely.

@jesper-friis jesper-friis merged commit 22b8252 into master Jun 20, 2024
16 of 17 checks passed
@jesper-friis jesper-friis deleted the fix-convert branch June 20, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants