-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get restrictions as dicts #225
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #225 +/- ##
==========================================
+ Coverage 78.34% 78.41% +0.07%
==========================================
Files 18 18
Lines 1690 1696 +6
==========================================
+ Hits 1324 1330 +6
Misses 366 366 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggested changes to the tutorial, but only wording. It looks very good!
I think we should change to return_dicts = True as default as also changing target to value is a breaking change. We just have to state very clearly in the release that this is done, and that thisis a breaking change on a a feature that was added in the previous realease.
Co-authored-by: Francesca L. Bleken <48128015+francescalb@users.noreply.github.com>
… changed the default to True.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice.
Description
Added a
return_dicts
keyword argument to theTriplestore.retrictions()
method, to allow to get the restrictions as dicts instead of blank nodes.Other changes:
target
argument ofTriplestore.add_retriction()
andTriplestore.retrictions()
tovalue
in order to be consistent with the naming in EMMOntoPy. These two methods are a very new addition to tripper that haven't been used yet. This change that this change will break existing code is therefore very small.Question
Should we change the default of
return_dicts
to be true? If so, this is the right time to do it, before people starts to use these methods.Type of change
Checklist for the reviewer
This checklist should be used as a help for the reviewer.