Added a fix for parsing rdflib literals. #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #229 +/- ##
==========================================
+ Coverage 78.41% 78.44% +0.02%
==========================================
Files 18 18
Lines 1696 1698 +2
==========================================
+ Hits 1330 1332 +2
Misses 366 366 ☔ View full report in Codecov by Sentry. |
francescalb
reviewed
Jul 1, 2024
francescalb
reviewed
Jul 1, 2024
| # This will handle rdflib literals correctly and probably most other | ||
| # literal representations as well. | ||
| # This should handle rdflib literals correctly (and probably most other | ||
| # literal representations as well) | ||
| if hasattr(literal, "value"): |
There was a problem hiding this comment.
But can a literal not have the attribute? Isn't it always there, but sometimes with value None? (I thought the reason for this fix is exactly that)
There was a problem hiding this comment.
Agree, the argument name literal is not very well chosen. It may be any Python object that can be converted to a literal (most of these do not have a value attribute). It was changed by Casper from obj to literal in one of his early reviews. Should we revert?
Co-authored-by: Francesca L. Bleken <48128015+francescalb@users.noreply.github.com>
francescalb
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We cannot use the
valueattribute of anrdflib.Literalto access its value, since it isNonefor some datatypes (at least for rdf:JSON).Seems more robust to use the existence of the
n3()method to test for a literal and the string representation to access its value.Type of change
Checklist for the reviewer
This checklist should be used as a help for the reviewer.