Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 refactor triplestore #27

Merged
merged 40 commits into from
Nov 2, 2022
Merged

3 refactor triplestore #27

merged 40 commits into from
Nov 2, 2022

Conversation

jesper-friis
Copy link
Contributor

@jesper-friis jesper-friis commented Oct 31, 2022

This is a new cleanup branch after all the mess that was introduced in #25

It has been reviewed several times and needs to be merged now. The only important issue that remains it that the CI workflow fails - most likely due to a bug in mypy.

jesper-friis and others added 29 commits October 23, 2022 20:54
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
…hub.com:EMMC-ASBL/tripper into 3-refactor-triplestorepy-triplestore-module-api
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
…hub.com:EMMC-ASBL/tripper into 3-refactor-triplestorepy-triplestore-module-api
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
…hub.com:EMMC-ASBL/tripper into 3-refactor-triplestorepy-triplestore-module-api
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2022

Codecov Report

Base: 71.02% // Head: 73.57% // Increases project coverage by +2.55% 🎉

Coverage data is based on head (792d962) compared to base (a8491a3).
Patch coverage: 82.99% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
+ Coverage   71.02%   73.57%   +2.55%     
==========================================
  Files           6       10       +4     
  Lines         528      598      +70     
==========================================
+ Hits          375      440      +65     
- Misses        153      158       +5     
Impacted Files Coverage Δ
tripper/triplestore.py 79.70% <65.51%> (-0.71%) ⬇️
tripper/utils.py 77.46% <77.46%> (ø)
tripper/literal.py 84.74% <84.74%> (ø)
tripper/namespace.py 91.13% <91.13%> (ø)
tripper/__init__.py 100.00% <100.00%> (ø)
tripper/backends/ontopy.py 37.93% <100.00%> (ø)
tripper/backends/rdflib.py 96.55% <100.00%> (ø)
tripper/errors.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jesper-friis jesper-friis merged commit 0289311 into main Nov 2, 2022
@jesper-friis jesper-friis deleted the 3-refactor-triplestore branch November 2, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants