Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate mapping routes from subclasses of Value and MappingStep #73

Merged
merged 6 commits into from
Jan 30, 2023

Conversation

jesper-friis
Copy link
Contributor

Added two new arguments to mapping_routes() such that we can generate mapping routes based on custom subclasses of Value and MappingStep.

mapping routes based on custom subclasses of Value and MappingStep.
@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2023

Codecov Report

Base: 66.94% // Head: 67.62% // Increases project coverage by +0.67% 🎉

Coverage data is based on head (14b507f) compared to base (a676c26).
Patch coverage: 70.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
+ Coverage   66.94%   67.62%   +0.67%     
==========================================
  Files          14       14              
  Lines        1074     1078       +4     
==========================================
+ Hits          719      729      +10     
+ Misses        355      349       -6     
Impacted Files Coverage Δ
tripper/triplestore.py 78.41% <ø> (ø)
tripper/mappings/mappings.py 50.87% <66.66%> (+2.83%) ⬆️
tripper/mappings/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jesper-friis jesper-friis merged commit aeaeeaa into main Jan 30, 2023
@jesper-friis jesper-friis deleted the allow-subclassing branch January 30, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants