-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documented return value of the Triplestore.query() and added a test for it #9
Conversation
- documented return value of Triplestore.query() method - improved documentation of arguments of query() and update() methods - ensure that the tests runs again - corredted return value of the query() method (for rdflib backend) and added tests
Codecov ReportBase: 69.35% // Head: 69.86% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
==========================================
+ Coverage 69.35% 69.86% +0.51%
==========================================
Files 6 6
Lines 509 511 +2
==========================================
+ Hits 353 357 +4
+ Misses 156 154 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still some EOL, function-defining colons missing in the interface.py
file.
The one I can see is for the namespaces
method.
If any pre-commit hooks (black, pylint, etc.) is run on these files, this would be caught immediately. Or a test, since the file is not parseable by the interpreter.
Edit: I see now that this is all in a documentation string. Please try to copy paste the code part of the doc-string then in a new file and go through it there, if it's the color-coding in your IDE that's not catching this. I can see the __init__
method is missing a colon as well...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Squash+merge at will
This ended up including: