Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documented return value of the Triplestore.query() and added a test for it #9

Merged
merged 11 commits into from
Oct 25, 2022

Conversation

jesper-friis
Copy link
Contributor

This ended up including:

  • documented return value of Triplestore.query() method
  • improved documentation of arguments of query() and update() methods
  • corrected return value of the query() method (for rdflib backend) and added tests
  • ensure that the tests runs again after the package was renamed

- documented return value of Triplestore.query() method
- improved documentation of arguments of query() and update() methods
- ensure that the tests runs again
- corredted return value of the query() method (for rdflib backend) and added
  tests
@jesper-friis jesper-friis requested a review from CasperWA October 9, 2022 08:31
@jesper-friis jesper-friis changed the title Documented return value of the Triplestore.query() and a test for it Documented return value of the Triplestore.query() and added a test for it Oct 9, 2022
@jesper-friis jesper-friis mentioned this pull request Oct 9, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2022

Codecov Report

Base: 69.35% // Head: 69.86% // Increases project coverage by +0.51% 🎉

Coverage data is based on head (4d66da5) compared to base (23d91f7).
Patch coverage: 88.88% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   69.35%   69.86%   +0.51%     
==========================================
  Files           6        6              
  Lines         509      511       +2     
==========================================
+ Hits          353      357       +4     
+ Misses        156      154       -2     
Impacted Files Coverage Δ
tripper/interface.py 0.00% <ø> (ø)
tripper/backends/ontopy.py 37.93% <66.66%> (-0.45%) ⬇️
tripper/backends/rdflib.py 93.47% <100.00%> (+2.36%) ⬆️
tripper/triplestore.py 80.11% <100.00%> (+0.58%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

tripper/interface.py Outdated Show resolved Hide resolved
tripper/interface.py Outdated Show resolved Hide resolved
tripper/interface.py Outdated Show resolved Hide resolved
tripper/backends/rdflib.py Show resolved Hide resolved
CasperWA and others added 4 commits October 20, 2022 10:49
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
@jesper-friis jesper-friis requested a review from CasperWA October 23, 2022 07:52
Copy link
Contributor

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some EOL, function-defining colons missing in the interface.py file.
The one I can see is for the namespaces method.

If any pre-commit hooks (black, pylint, etc.) is run on these files, this would be caught immediately. Or a test, since the file is not parseable by the interpreter.
Edit: I see now that this is all in a documentation string. Please try to copy paste the code part of the doc-string then in a new file and go through it there, if it's the color-coding in your IDE that's not catching this. I can see the __init__ method is missing a colon as well...

@jesper-friis jesper-friis requested a review from CasperWA October 24, 2022 21:58
Copy link
Contributor

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Squash+merge at will

@jesper-friis jesper-friis merged commit f6d42f9 into main Oct 25, 2022
@jesper-friis jesper-friis deleted the query-return-value branch October 25, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants