Skip to content

Conversation

@paulhazen
Copy link
Contributor

@paulhazen paulhazen commented Dec 16, 2024

The following PR adds unit tests that confirm the equivalency of config values as read from the native and managed components of the plugin.

[!IMPORTANT]
This PR has been moved to draft pending an internal discussion regarding the best testing framework to utilize.

Note

Discussion was had internally, and it was agreed that having tests in some framework was preferable to having no tests - and that changing testing frameworks would be something trivial to do at a later date if it was deemed necessary.

#EOS-1982

…stead of pointers to values - and update the test suite to test not just eos sdk initialize options but also platform create options.
@paulhazen paulhazen added enhancement New feature or request unit-testing PRs that introduce additional Unit Testing labels Dec 16, 2024
@paulhazen paulhazen self-assigned this Dec 16, 2024
@paulhazen paulhazen changed the base branch from development to fix/native-use-new-config December 16, 2024 02:16
@paulhazen paulhazen marked this pull request as ready for review December 16, 2024 02:17
@arthur740212
Copy link
Contributor

arthur740212 commented Dec 17, 2024

Not so comfortable that the solution requires the test to compile.

The solution only requires the tests to compile if in Debug mode - otherwise the Test project is not required.

I feel like a test like this is better in a separate solution.

It's standard practice to put test projects in the same solution as the projects that they are designed to test.

Also there is an extra .net 4.8 dependency introduced somewhere that I'm not quite sure why.

That dependency is only for ManagedPluginCode, which is an existing dependency not introduced by this PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we need to discuss testing frameworks.

@paulhazen paulhazen marked this pull request as draft December 18, 2024 19:59
@paulhazen paulhazen changed the base branch from fix/native-use-new-config to development December 21, 2024 02:09
@paulhazen
Copy link
Contributor Author

I believe we need to discuss testing frameworks.

We've now had the discussion internally - and I believe that the consensus was to include these tests as it would be easy to change unit testing frameworks later, and would be good to have tests in some framework rather than no tests at all.

@paulhazen paulhazen marked this pull request as ready for review January 7, 2025 19:02
@paulhazen paulhazen merged commit 7c28654 into development Feb 7, 2025
1 check passed
@EpicCliffHudson EpicCliffHudson deleted the tests/native-render branch September 23, 2025 03:31
@EpicCliffHudson EpicCliffHudson restored the tests/native-render branch September 23, 2025 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request unit-testing PRs that introduce additional Unit Testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants