-
Notifications
You must be signed in to change notification settings - Fork 63
test: Native Render #1059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Native Render #1059
Conversation
…ged initialize options.
…stead of pointers to values - and update the test suite to test not just eos sdk initialize options but also platform create options.
… added clarifying comments to the tests.
lib/NativeCode/DynamicLibraryLoaderHelper/NativeRender/src/eos_helpers.cpp
Outdated
Show resolved
Hide resolved
lib/NativeCode/DynamicLibraryLoaderHelper/ManagedPluginCode/Application.cs
Show resolved
Hide resolved
The solution only requires the tests to compile if in
It's standard practice to put test projects in the same solution as the projects that they are designed to test.
That dependency is only for |
andrew-hirata-playeveryware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we need to discuss testing frameworks.
We've now had the discussion internally - and I believe that the consensus was to include these tests as it would be easy to change unit testing frameworks later, and would be good to have tests in some framework rather than no tests at all. |
The following PR adds unit tests that confirm the equivalency of config values as read from the native and managed components of the plugin.
Note
Discussion was had internally, and it was agreed that having tests in some framework was preferable to having no tests - and that changing testing frameworks would be something trivial to do at a later date if it was deemed necessary.
#EOS-1982