feat: Display & Make editable the Encryption Key for Client Credentials #1105
Conversation
paulhazen
added
enhancement
paulhazen
requested review from
WispyMouse,
andrew-hirata-playeveryware and
arthur740212
com.playeveryware.eos/Runtime/Core/EOS_SDK_Additions/EOSClientCredentials.cs
Show resolved
Hide resolved
paulhazen
changed the title
…files and add documentation to them as-is appropriate.
WispyMouse
force-pushed
the
fix/display-encryption-key
branch
from
5bb00cf to
5478e63
Compare
|
Retargeted to |
| (rect, item, nameAsLabel) => // Things function renders input for a EOSClientCredential item. | ||
| { | ||
| float remainingWidth = rect.width; | ||
| float remainingWidth = rect.width - 5f; |
There was a problem hiding this comment.
nit: I'm wondering if we want to assign '5' to a variable representing 'X button width' or something. I see '5' used in 4 places in this PR.
WispyMouse
left a comment
WispyMouse
left a comment
There was a problem hiding this comment.
Tiny aesthetic problem: Open the key window, and mouse over the text field. I expect there would be a text cursor there indicating I'm mousing over a field, but instead it retains the previous cursor contextual state. I do not know why it does this. I suspect that might play poorly with some people's screens, but I have no repro case of this being a problem.
WispyMouse
left a comment
WispyMouse
left a comment
There was a problem hiding this comment.
Approved. I was able to get it into a bad state somehow, but I wasn't able to reproduce it again. I tried throwing all sorts of stuff at this and it seemed to hold up.
I recall having a similar problem - I suspect it has to do with how the Unity Editor handles scenarios where it has loaded a new window that it has never rendered before - I've noticed this sort of behavior a lot when adding new windows. Might we worth filing a bug with Unity.... |
This PR allows the Encryption Key for Client Credentials to be displayed and updated.
#EOS-2379