String Extensions #893
Merged
String Extensions #893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulhazen
added
enhancement
paulhazen
requested review from
WispyMouse,
andrew-hirata-playeveryware and
arthur740212
WispyMouse
reviewed
Sep 4, 2024
com.playeveryware.eos/Runtime/Core/Extensions/StringExtensions.cs
Outdated
Show resolved
Hide resolved
WispyMouse
approved these changes
Sep 4, 2024
Contributor
WispyMouse
left a comment
WispyMouse
left a comment
There was a problem hiding this comment.
Seems good to me. I tried to look up if there was any difference between ulong and uint64, but it appears as though C# treats them effectively identically.
andrew-hirata-playeveryware
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process of implementing config overrides, it made sense to relegate the conversion of strings to
ulongwith a default value to aStringExtensionsclass. This change is put into a separate PR so that the PR containing the changes for the attached task can be evaluated in isolation.#EOS-1982