Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Commit

Permalink
pass along trigger_send
Browse files Browse the repository at this point in the history
  • Loading branch information
@heifner
heifner committed Nov 27, 2018
1 parent 26bf33b commit 3d99414
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion plugins/net_plugin/net_plugin.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1132,7 +1132,7 @@ namespace eosio {
fc::raw::pack( ds, unsigned_int( which ));
fc::raw::pack( ds, *sb );

enqueue_buffer( send_buffer, true, no_reason );
enqueue_buffer( send_buffer, trigger_send, no_reason );
}

void connection::enqueue_buffer( const std::shared_ptr<std::vector<char>>& send_buffer, bool trigger_send, go_away_reason close_after_send ) {
Expand Down

1 comment on commit 3d99414

@pmesnier
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since the "trigger_send" value is only ever used by the enqueue_sync_block() function, a better fix would be to simply remove the defaulted trigger_send from the enqueue() signature. If you don't like the explicit use of true in the call, we can reorder the signature of enqueue_bufer() so trigger_send defaulted to true is the last parameter.

Please sign in to comment.