Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Create backend for wallet #165

Closed
heifner opened this issue Aug 14, 2017 · 8 comments
Closed

Create backend for wallet #165

heifner opened this issue Aug 14, 2017 · 8 comments
Assignees
@heifner

Comments

@heifner
Copy link
Contributor

heifner commented Aug 14, 2017

Create required backend api to support wallet ui
@heifner heifner self-assigned this Aug 14, 2017
@heifner
Copy link
Contributor Author

heifner commented Aug 15, 2017

  • Add eosd plugin for wallet
    • accept http requests only from localhost
  • eosc interact with eosd running with only wallet plugin
    • eosc sends unlock w/ password and optional timeout
    • also needs interface for lock/create/import_key/keys
  • eosc interact with eosd running with chain
    • also connects to eosd running with wallet
    • requests eosd with wallet to sign transaction
    • sends signed transaction on to eosd with chain
  • Update docs with new interaction instructions

@heifner
Copy link
Contributor Author

heifner commented Aug 18, 2017

Using an old comment in eosc as general requirements:

  • eosc unlock walletname PASSWORD
  • eosc create wallet walletname PASS1 PASS2
  • eosc unlock walletname PASSWORD
  • eosc wallets -> prints list of wallets with * next to currently unlocked
  • eosc keys -> prints list of private keys
  • eosc importkey privatekey -> loads keys
  • eosc accounts -> prints list of accounts that reference key
  • eosc lock

Do we plan to associate wallet or key in a wallet to an authority? The transaction signatures appear to just be appended without any authority association. So maybe the idea is to just sign the transaction with all the unlocked wallets keys.

@bytemaster
Copy link
Contributor

Transactions have to be signed by the minimum set of keys or they will be rejected.

There should be an API that allows you to send the PUBLIC keys of the wallet along with the transcation to EOSD and then get returned the set of PUBLIC keys that should be used to sign. Answering this question requires access to the chain database and thus is most efficiently calculated on the server.

@heifner
Copy link
Contributor Author

heifner commented Aug 25, 2017

There should be an API that allows you to send the PUBLIC keys of the wallet along with the transcation to EOSD and then get returned the set of PUBLIC keys that should be used to sign. Answering this question requires access to the chain database and thus is most efficiently calculated on the server.

I will add this as part of this issue.

@heifner
Copy link
Contributor Author

heifner commented Aug 25, 2017 •
edited
Loading

Taking this issue out of in progress so I can help the wallet ui guys understand the json they need in order to interact with eosd.

To complete this issue, currently waiting on:

@heifner
Copy link
Contributor Author

heifner commented Aug 30, 2017 •
edited
Loading

  • Add get_required_keys to chain_controller
  • Add API hook to EOSD for CLI wallet to send list of public keys with transaction and get back a list of used keys. Call the above get_required_keys.
  • Update wallet manager to use new api to sign transaction
  • Determine mechanism to specify walletd endpoint in eosc
  • Merge/add wallet CLI commands to eosc with inline doc
  • Remove unneeded wallet_data attributes

@heifner heifner mentioned this issue Aug 30, 2017
Closed
@heifner
Copy link
Contributor Author

heifner commented Aug 31, 2017

I put the pull request back into needs review. I believe I have everything you requested. We do need to discuss the multiple wallets. It might not be a feature you needed, but it does allow a user to have multiple if they do wish to segment their keys.

@heifner
Copy link
Contributor Author

heifner commented Sep 12, 2017

eos-walletd added and merged. Closing.

@heifner heifner closed this as completed Sep 12, 2017
ljrprocc pushed a commit to bithacks-tech/myeosio that referenced this issue Jul 4, 2018
Merge pull request EOSIO#165 from enumivo/staging
ff0e069 
Staging
NorseGaud pushed a commit that referenced this issue Jul 30, 2019
# This is a combination of 186 commits.
6c09577 
# This is the 1st commit message:

various improvements

# This is the commit message #2:

new hash

# This is the commit message #3:

fix for script path

# This is the commit message #4:

fixes

# This is the commit message #5:

fixes

# This is the commit message #6:

fixes

# This is the commit message #7:

fixes

# This is the commit message #8:

fixes

# This is the commit message #9:

fixes

# This is the commit message #10:

fixes

# This is the commit message #11:

fixes

# This is the commit message #12:

fixes

# This is the commit message #13:

fixes

# This is the commit message #14:

fixes

# This is the commit message #15:

fixes

# This is the commit message #16:

fixes

# This is the commit message #17:

fixes

# This is the commit message #18:

fixes

# This is the commit message #19:

fixes

# This is the commit message #20:

fixes

# This is the commit message #21:

fixes

# This is the commit message #22:

fixes

# This is the commit message #23:

fixes

# This is the commit message #24:

fixes

# This is the commit message #25:

fixes

# This is the commit message #26:

testing

# This is the commit message #27:

testing

# This is the commit message #28:

testing

# This is the commit message #29:

testing

# This is the commit message #30:

testing

# This is the commit message #31:

testing

# This is the commit message #32:

testing

# This is the commit message #33:

testing

# This is the commit message #34:

testing

# This is the commit message #35:

testing

# This is the commit message #36:

testing

# This is the commit message #37:

testing

# This is the commit message #38:

testing

# This is the commit message #39:

testing

# This is the commit message #40:

testing

# This is the commit message #41:

testing

# This is the commit message #42:

testing

# This is the commit message #43:

testing

# This is the commit message #44:

fixes

# This is the commit message #45:

fixes

# This is the commit message #46:

fixes

# This is the commit message #47:

fixes

# This is the commit message #48:

fixes

# This is the commit message #49:

fixes

# This is the commit message #50:

fixes

# This is the commit message #51:

fixes

# This is the commit message #52:

fixes

# This is the commit message #53:

fixes

# This is the commit message #54:

fixes

# This is the commit message #55:

fixes

# This is the commit message #56:

fixes

# This is the commit message #57:

fixes

# This is the commit message #58:

fixes

# This is the commit message #59:

fixes

# This is the commit message #60:

fixes

# This is the commit message #61:

fixes

# This is the commit message #62:

fixes

# This is the commit message #63:

fixes

# This is the commit message #64:

fixes

# This is the commit message #65:

fixes

# This is the commit message #66:

fixes

# This is the commit message #67:

fixes

# This is the commit message #68:

fixes

# This is the commit message #69:

fixes

# This is the commit message #70:

fixes

# This is the commit message #71:

fixes

# This is the commit message #72:

fixes

# This is the commit message #73:

fixes

# This is the commit message #74:

fixes

# This is the commit message #75:

fixes

# This is the commit message #76:

fixes

# This is the commit message #77:

fixes

# This is the commit message #78:

fixes

# This is the commit message #79:

more testing

# This is the commit message #80:

testing

# This is the commit message #81:

fixes

# This is the commit message #82:

fixes

# This is the commit message #83:

fixes

# This is the commit message #84:

fixes

# This is the commit message #85:

fixes

# This is the commit message #86:

fixes

# This is the commit message #87:

fixes

# This is the commit message #88:

fixes

# This is the commit message #89:

fixes

# This is the commit message #90:

fixes

# This is the commit message #91:

fixes

# This is the commit message #92:

fixes

# This is the commit message #93:

propagate-environment for buildkite-agent

# This is the commit message #94:

propagate-environment for buildkite-agent

# This is the commit message #95:

propagate-environment for buildkite-agent

# This is the commit message #96:

propagate-environment for buildkite-agent

# This is the commit message #97:

fixes

# This is the commit message #98:

fixes

# This is the commit message #99:

fixes

# This is the commit message #100:

fixes

# This is the commit message #101:

fixes

# This is the commit message #102:

fixes

# This is the commit message #103:

fixes

# This is the commit message #104:

fixes

# This is the commit message #105:

fixes

# This is the commit message #106:

fixes

# This is the commit message #107:

fixes

# This is the commit message #108:

fixes

# This is the commit message #109:

fixes

# This is the commit message #110:

fixes

# This is the commit message #111:

fixes

# This is the commit message #112:

fixes

# This is the commit message #113:

fixes

# This is the commit message #114:

fixes

# This is the commit message #115:

fixes

# This is the commit message #116:

fixes

# This is the commit message #117:

fixes

# This is the commit message #118:

fixes

# This is the commit message #119:

fixes

# This is the commit message #120:

fixes

# This is the commit message #121:

fixes

# This is the commit message #122:

fixes

# This is the commit message #123:

fixes

# This is the commit message #124:

fixes

# This is the commit message #125:

fixes

# This is the commit message #126:

fixes

# This is the commit message #127:

fixes

# This is the commit message #128:

fixes

# This is the commit message #129:

fixes

# This is the commit message #130:

fixes

# This is the commit message #131:

fixes

# This is the commit message #132:

fixes

# This is the commit message #133:

fixes

# This is the commit message #134:

fixes

# This is the commit message #135:

fixes

# This is the commit message #136:

fixes

# This is the commit message #137:

fixes

# This is the commit message #138:

fixes

# This is the commit message #139:

fixes

# This is the commit message #140:

fixes

# This is the commit message #141:

fixes

# This is the commit message #142:

fixes

# This is the commit message #143:

fixes

# This is the commit message #144:

fixes

# This is the commit message #145:

fixes

# This is the commit message #146:

fixes

# This is the commit message #147:

fixes

# This is the commit message #148:

fixes

# This is the commit message #149:

fixes

# This is the commit message #150:

fixes

# This is the commit message #151:

fixes

# This is the commit message #152:

fixes

# This is the commit message #153:

testing

# This is the commit message #154:

fixes

# This is the commit message #155:

fixes

# This is the commit message #156:

fixes

# This is the commit message #157:

fixes

# This is the commit message #158:

fixes

# This is the commit message #159:

fixes

# This is the commit message #160:

fixes

# This is the commit message #161:

fixes

# This is the commit message #162:

fixes

# This is the commit message #163:

fixes

# This is the commit message #164:

fixes

# This is the commit message #165:

fixes

# This is the commit message #166:

fixes

# This is the commit message #167:

fixes

# This is the commit message #168:

fixes

# This is the commit message #169:

fixes

# This is the commit message #170:

fixes

# This is the commit message #171:

fixes

# This is the commit message #172:

fixes

# This is the commit message #173:

fixes

# This is the commit message #174:

fixes

# This is the commit message #175:

fixes

# This is the commit message #176:

fixes

# This is the commit message #177:

fixes

# This is the commit message #178:

fixes

# This is the commit message #179:

fixes

# This is the commit message #180:

fixes

# This is the commit message #181:

fixes

# This is the commit message #182:

fixes

# This is the commit message #183:

fixes

# This is the commit message #184:

fixes

# This is the commit message #185:

fixes

# This is the commit message #186:

fixes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@heifner heifner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bytemaster @heifner