Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Contract Memory Initialization is Wrong in Several Ways #425

Closed
bytemaster opened this issue Sep 14, 2017 · 4 comments
Closed

Contract Memory Initialization is Wrong in Several Ways #425

bytemaster opened this issue Sep 14, 2017 · 4 comments
Assignees
Labels
Milestone

Comments

@bytemaster
Copy link
Contributor

In wasm_interface::load(...)

  1. it only checks first 10000 bytes for non-0 initial state, this will fail on WASM modules that define static data beyond the first 10K bytes
  2. it doesn't check the proper memory size.
@brianjohnson5972
Copy link
Contributor

@bytemaster Is 2 just stating that it needs to correctly loop over the full memory, or what other check is needed?

@brianjohnson5972
Copy link
Contributor

@bytemaster Did I complete this with my commit that checks the for the default memory size, or is there more to handle this?

@brianjohnson5972
Copy link
Contributor

@thomasbcox or @bytemaster - I'd like to get this closed, can I get some input?

@Aspian123 Aspian123 modified the milestones: EOS Dawn 1.1, EOS Dawn 2.0 Nov 1, 2017
@heifner
Copy link
Contributor

heifner commented Nov 6, 2017

Resolved by #490

@heifner heifner closed this as completed Nov 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants