Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

DAWN-376 account history scope refactor fix #1111

Merged
merged 2 commits into from
Jan 16, 2018
Merged

DAWN-376 account history scope refactor fix #1111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12fa33d
Fixed applied_block call.
brianjohnson5972 Jan 16, 2018
5e3c22a
Making block_trace creation with signed_block to be explicit.
brianjohnson5972 Jan 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libraries/chain/include/eosio/chain/block.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ namespace eosio { namespace chain {
};

struct block_trace {
block_trace(const signed_block& s)
explicit block_trace(const signed_block& s)
:block(s)
{}

Expand Down
2 changes: 1 addition & 1 deletion plugins/account_history_plugin/account_history_plugin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,7 @@ void account_history_plugin::plugin_startup()
db.add_index<transaction_history_multi_index>();

my->chain_plug->chain().applied_block.connect ([&impl = my](const chain::block_trace& trace) {
impl->applied_block(trace.block);
impl->applied_block(trace);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I vote we add explicit to block.hpp block_trace(const signed_block& s); constructor.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, added.

});
}

Expand Down