This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Storage #494
Merged
Storage #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bytemaster
reviewed
Sep 26, 2017
| } | ||
| } | ||
|
|
||
| void apply_storage_transfer( const TOKEN_NAME::Transfer& transfer ) { |
There was a problem hiding this comment.
storage doesn't implement a currency...
bytemaster
reviewed
Sep 26, 2017
| /// The apply method implements the dispatch of events to this contract | ||
| void apply( uint64_t code, uint64_t action ) { | ||
| if( code == N(storage) ) { | ||
| if( action == N(transfer) ) { |
There was a problem hiding this comment.
this should be code == EOS and action == transfer... apply_eos_transfer(...)
bytemaster
reviewed
Sep 26, 2017
| /** | ||
| * quantity to transfer | ||
| */ | ||
| StorageTokens quantity; |
There was a problem hiding this comment.
We don't create StorageTokens and storage, instead we have storage quota and storage consumed and its measured in bytes.
bytemaster
approved these changes
Sep 26, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first cut implementation of storage contract. Does not do anything yet. Still needs implementation of reserving tokens for storage and freeing tokens when storage is released.
Also methods to read structures from message are yet to be implemented. Issues #493 and #492