This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Updated db C++ API for string type primary key #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavybez
changed the title
elmato
approved these changes
Sep 26, 2017
bytemaster
reviewed
Sep 26, 2017
| struct table_impl_obj {}; | ||
|
|
||
| template<> | ||
| struct table_impl_obj<char*> { |
There was a problem hiding this comment.
We should define a string class and not use char* as strings in c++ apis.
bytemaster
approved these changes
Sep 26, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated db C++ API with new implementation for defining VarTable that can take String as primary key or any other object in future.