Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

replay ctrl-c support #6237

Merged
merged 5 commits into from
Nov 20, 2018
Merged

replay ctrl-c support #6237

merged 5 commits into from
Nov 20, 2018

Conversation

heifner
Copy link
Contributor

@heifner heifner commented Nov 5, 2018

Change Description

  • Resolves Control+C during replay causes a crash #3338
  • Appbase updated to post plugin startup() of plugins so signals can interrupt after each plugin startup()
  • Appbase signal handling moved to a dedicated thread so signals interruption can be handled while plugin startup() in the middle of processing
  • Check if shutdown has been signaled while replaying to allow interruption
  • Allow startup from a previously stopped replay to start where replay ended

Consensus Changes

None

API Changes

None

Documentation Additions

  • Update to indicate that ctrl-c (SIGINT, SIGTERM, SIGPIPE) during replay no longer requires a --hard-replay-blockchain or a --replay-blockchain
  • After a ctrl-c during a --replay-blockchain simply restart without the --replay-blockchain option.

Copy link
Contributor

@wanderingbort wanderingbort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are upstream comments in appbase but this looks fine. Once the the upstream changes are resolved, I will swap this to an approve.

@heifner
Copy link
Contributor Author

heifner commented Nov 16, 2018

appbase PR merged and this PR updated to point to the latest master of appbase.

@heifner heifner merged commit 23aefd9 into develop Nov 20, 2018
@heifner heifner deleted the gh#3338-replay branch November 20, 2018 14:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants