This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
cleos: fix broken -r,--header - was passing headers after the double CRLF #6265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `-r` or `--header` feature was broken, as headers were sent *after* the last double CRLF. Since this feature is broken, perhaps it was never used. I suggest we rename `-r` to `-H` to make it more `curl`-like.
abourget
changed the title
abourget
changed the title
spoonincode
approved these changes
Nov 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
The
-ror--headerfeature was broken, as headers were sent after the last double CRLF.Since this feature is broken, perhaps it was never used. I suggest we rename
-rto-Hto make it morecurl-like.Consensus Changes
None
API Changes
None (yet, unless we rename
-rto-Hplease? :)Documentation Additions
None