This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Enhancements to cleos multisig: approve with proposal_hash, invalidate, and improved review #6356
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Resolves #6272.
Special shoutout to @conr2d who took the initiative to resolve #6272 with PR #6298. There were undocumented plans to improve the
cleos multisig
sub-commands which this PR addresses in addition to the enhancements described in #6272. So this PR ultimately ended up superseding PR #6298.Adds optional
proposal_hash
argument tocleos multisig approve
to support the new safety feature introduce to theeosio.msig
contract in EOSIO/eosio.contracts#121.Adds the
cleos multisig invalidate
sub-command to call theinvalidate
action of theeosio.msig
contract introduced in EOSIO/eosio.contracts#59.Modifies the
cleos multisig review
sub-command:Adds
proposer
andtransaction_id
fields to the returned JSON. Thetransaction_id
in particular is useful since that is the hash that would need to be passed in asproposal_hash
in thecleos multisig approve
sub-command (assuming the user wants to use that optional feature for added security).Adds cleos option
--show-approvals
which if enabled will add an extra array fieldapprovals
to the returned JSON. Thisapprovals
field is a list of all the requested approvals for the proposed transaction along with their status: unapproved, approved, invalidated. Approval time, unapproval time, and invalidation time may also be present if appropriate. Theapprovals
field will still correctly show up (assuming it is requested with the--show-approvals
option) even if theeosio.msig
contract is an old version; however, certain features, such asinvalidation
status and approval/unapproval times, will of course not be available.Consensus Changes
None
API Changes
None
Documentation Additions
Documentation for cleos needs to be updated to reflect the changes described above.