Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Enhancements to cleos multisig: approve with proposal_hash, invalidate, and improved review #6356

Merged
merged 2 commits into from
Nov 20, 2018

Conversation

arhag
Copy link
Contributor

@arhag arhag commented Nov 20, 2018

Change Description

Resolves #6272.

Special shoutout to @conr2d who took the initiative to resolve #6272 with PR #6298. There were undocumented plans to improve the cleos multisig sub-commands which this PR addresses in addition to the enhancements described in #6272. So this PR ultimately ended up superseding PR #6298.

Adds optional proposal_hash argument to cleos multisig approve to support the new safety feature introduce to the eosio.msig contract in EOSIO/eosio.contracts#121.

Adds the cleos multisig invalidate sub-command to call the invalidate action of the eosio.msig contract introduced in EOSIO/eosio.contracts#59.

Modifies the cleos multisig review sub-command:

  • Adds proposer and transaction_id fields to the returned JSON. The transaction_id in particular is useful since that is the hash that would need to be passed in as proposal_hash in the cleos multisig approve sub-command (assuming the user wants to use that optional feature for added security).

  • Adds cleos option --show-approvals which if enabled will add an extra array field approvals to the returned JSON. This approvals field is a list of all the requested approvals for the proposed transaction along with their status: unapproved, approved, invalidated. Approval time, unapproval time, and invalidation time may also be present if appropriate. The approvals field will still correctly show up (assuming it is requested with the --show-approvals option) even if the eosio.msig contract is an old version; however, certain features, such as invalidation status and approval/unapproval times, will of course not be available.

Consensus Changes

None

API Changes

None

Documentation Additions

Documentation for cleos needs to be updated to reflect the changes described above.

@arhag arhag merged commit ffb581e into develop Nov 20, 2018
@arhag arhag deleted the cleos-multisig-enhancements branch November 20, 2018 17:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants