This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Pull in changes to build scripts that were merged to develop #6362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zreyn
approved these changes
Nov 20, 2018
wanderingbort
suggested changes
Nov 20, 2018
| @@ -3,7 +3,7 @@ | |||
| VERS=`sw_vers -productVersion | awk '/10\.13\..*/{print $0}'` | |||
| if [[ -z "$VERS" ]]; | |||
| then | |||
| VERS=`sw_vers -productVersion | awk '/10\.14\..*/{print $0}'` | |||
| VERS=`sw_vers -productVersion | awk '/10\.14.*/{print $0}'` | |||
There was a problem hiding this comment.
Are there version strings that omit the dot after 10.14, if so, is that the same for line 3 where we have 10.13. as the literal match?
There was a problem hiding this comment.
For some reason the mojave version string is just 10.14 where as high sierra is 10.13.xx. So in the case of high sierra we need that extra dot.
wanderingbort
approved these changes
Nov 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Pulls in changes to build scripts that were merged into develop
Consensus Changes
API Changes
Documentation Additions