This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Return 400 on get_block with nonexist block number [Issue 6374] #6490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgiszczak
suggested changes
Dec 17, 2018
For issue 6374
necokeine
changed the title
|
Thank you for review this code, it is my first time to send a merge request on Github. I have several questions here.
|
|
@necokeine Please develop on |
jgiszczak
approved these changes
Dec 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return 404 on get_block with uonexist block number.
Resolves #6374
Change Description
Consensus Changes
API Changes
Documentation Additions