This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now compiles, but the tests fail due to bugs.
…e_traces #6897 Also correct state history ABI for action_trace_v0 to reflect that inline_traces are no longer included.
6897 restructure traces test cases
heifner
suggested changes
Apr 9, 2019
heifner
approved these changes
Apr 10, 2019
This was referenced Apr 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Resolves #6897.
Modifies transaction trace structure:
account_ram_delta
totransaction_trace
which, if present, tracks the delta in RAM usage for the payer for the deferred transaction. (Note that the RAM initially billed for a contract-generated deferred transaction is not included as part of this field.)inline_traces
fromaction_trace
and switches to flat structure for all action traces.action_trace
:receiver
which is the receiver of the action (identical to the one inside thereceipt
, if present);action_ordinal
an unsigned integer used to identify the action trace within the transaction;creator_action_ordinal
is the ordinal of the action trace that is the parent of the current action trace within the creation tree representation of the transaction trace;parent_action_ordinal
is the ordinal of the action trace that is the parent of the current action trace within the execution tree representation of the transaction trace.On error, the transaction trace will now included the action traces for any actions that were scheduled but not yet successfully executed by the point of the error. Any action that has not successfully executed will have an empty
receipt
.The
history_plugin
,mongo_db_plugin
, andstate_history_plugin
have been modified to work with thetransaction_trace
structure.The
push_transaction
andpush_transactions
RPCs of the chain API have been modified to convert the new transaction trace structure back into a format similar to the old structure prior to returning the converted result back to the client. The converted structure recovers the old "execution tree" representation (using theinline_traces
field which is brought back) that existing clients may be expecting. However, the new fields in bothtransaction_trace
andaction_trace
are still included in this converted structure.A new RPC
send_transaction
has been added to the chain API which does the same thing aspush_transaction
except it does not do any conversion back to the old structure. It returns thetransaction_trace
as it is with the new flat structure.New test cases have been added to
api_tests
to verify the structure of thetransaction_trace
after executing variations of the example scenario discussed in #6897.Consensus Changes
API Changes
Add
send_transaction
RPC to chain API.Documentation Additions
Documentation will need to be updated to include the new
send_transaction
RPC as part of the chain API.send_transaction
is preferred overpush_transaction
since it avoids doing the additional conversion work thatpush_transaction
now does to support backwards compatibility.The structure of
transaction_trace
has been modified which has an impact to any plugins that may be consuming theapplied_transaction
signal.