This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Readlink bats fix r1.8 #7528
Merged
Readlink bats fix r1.8 #7528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See BATS tests passing here: https://buildkite.com/EOSIO/eosio-base-images/builds/285 |
arhag
approved these changes
Jun 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
The readlink tool throws a return code of 1 if the path is not a symlink. It used to be a symlink /usr/bin/c++ -> /usr/bin/clang++ but since #7516, we need to return true regardless of readlink failing and check if CXX =~ clang already.
In addition, this also includes fixes and adjustments for the BATS tests to support both the new installation path prompt and changes to the ensure-compiler helper function. I am continuing to refine the BATS tests while we investigate issues with builds on clean containers to ensure we check for the correct dependencies.
NOTE: This is a backport of #7525 for release 1.8.x.