This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
return more from producer_plugin's get_runtime_options() #8231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you know why this resolves the Ubuntu build issue? |
|
Nope, I don't. I would like to know why too. |
swatanabe-b1
approved these changes
Nov 20, 2019
3 tasks
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Return more information -- all the fields of
runtime_options-- from producer plugin'sget_runtime_options. This, interestingly enough, resolves the Ubuntu 18.04 build issue in #8216. Since returning all the parameters seems useful anyways this might as well be the fix for that problem.Consensus Changes
API Changes
Documentation Additions