This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Exit transaction early when insufficient account cpu - 2.0 #8638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cpu to execute according to last time trx was executed.
… of explicit_billed_cpu_time
…ch push_transaction
…g with tx_cpu_usage_exceeded so correct exception thrown in early eval of previously billed cpu
…on. Rename failure_is_subjective to block_is_exhausted to better reflect what the function does.
| @@ -172,6 +172,11 @@ namespace eosio { namespace chain { | |||
| deadline_exception_code = billing_timer_exception_code; | |||
| } | |||
|
|
|||
| if( !explicit_billed_cpu_time ) { | |||
| // if account no longer has enough cpu to exec trx, don't try | |||
| validate_account_cpu_usage( billed_cpu_time_us, account_cpu_limit ); | |||
There was a problem hiding this comment.
This doesn't seem to take leeway or the block cpu limit into account.
There was a problem hiding this comment.
Good catch. @arhag and I discussed that and came to the conclusion that it should be fine that it doesn't take leeway into account.
There was a problem hiding this comment.
Won't that effectively make leeway useless?
There was a problem hiding this comment.
This only comes into play on unapplied transactions. So if not applied before then leeway will be in effect. Leeway will just not be used for unapplied transactions.
There was a problem hiding this comment.
If we start relaying the billed_cpu_time over the p2p network then we will have to factor in leeway somehow.
arhag
suggested changes
Feb 14, 2020
arhag
approved these changes
Feb 20, 2020
arhag
approved these changes
Feb 20, 2020
This was referenced Feb 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Consensus Changes
API Changes
Documentation Additions