This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Create a fix to support requested encoding type in next_key #9917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nickjjzhao Please verify that the my edit to the initial description is correct. I'm guessing that you had made the PR via the hub tool. |
Thanks Brian! Your edit is correct. |
kimjh2005
reviewed
Jan 19, 2021
kimjh2005
reviewed
Jan 19, 2021
kimjh2005
reviewed
Jan 19, 2021
kimjh2005
approved these changes
Jan 19, 2021
brianjohnson5972
suggested changes
Jan 19, 2021
brianjohnson5972
suggested changes
Jan 20, 2021
nickjjzhao
force-pushed
the
jjz-epe530-kv-next_key
branch
from
dfef0da
to
1a86555
Compare
brianjohnson5972
approved these changes
Jan 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
The fix in this PR is to make sure that the value returned in "
next_key" matches the--encode-typeof the request that caused it to be returned (and thus can be used to replace the original passed in--lower, or--upperwith--reverse, parameter and the request repeated).Change Type
Select ONE:
Testing Changes
Select ANY that apply:
Consensus Changes
API Changes
Documentation Additions