-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow applying the tooltip to a specific layer #1399
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for eoxelements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks straightforward, but I cannot comment on the implementation. I'm just commenting on the API.
@@ -8,6 +8,7 @@ export class EOxMapTooltip extends LitElement { | |||
static get properties() { | |||
return { | |||
feature: { attribute: false, property: true, type: Object }, | |||
for: { attribute: "for", property: true, type: String }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually for
is used for DOM specifiers. Maybe we should use a different property for the layer ID.
Implemented changes
This introduces an option to provide a layer id for the
eox-map
tooltip. By default the tooltip renders for the topmost interaction layer, but can be set to specifically render for one layer:Related to #1358, #594
Screenshots/Videos
Screencast.from.2024-11-27.15.36.32.webm
Checklist before requesting a review